Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix build of dependencies #187

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

pinotree
Copy link
Contributor

  • fix the cmakeFlags specification for cereal, as it must be a string (and not a simple string)
  • build immer and zug explicitly disabling tests and examples, as they are neither run nor installed

@pinotree pinotree mentioned this pull request Jul 30, 2023
@arximboldi
Copy link
Owner

Nice one! Will merge once the tests run.

- fix the cmakeFlags specification for cereal, as it must be a string
  (and not a simple string)
- build immer and zug explicitly disabling tests and examples, as they
  are neither run nor installed
@codecov-commenter
Copy link

Codecov Report

Merging #187 (3860a30) into master (a2eceee) will not change coverage.
The diff coverage is n/a.

❗ Current head 3860a30 differs from pull request most recent head 9547f91. Consider uploading reports for the commit 9547f91 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          81       81           
  Lines        2875     2875           
=======================================
  Hits         2725     2725           
  Misses        150      150           

@arximboldi arximboldi merged commit 69ab331 into arximboldi:master Jul 31, 2023
7 checks passed
@pinotree pinotree deleted the fix-nix-deps branch August 1, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants